feat(CDN): Support emoji size #9787

Jiralite · 2023-08-20T13:58:15Z

Please describe the changes this PR makes and why it should be merged:
size may affect emojis:

Status and versioning classification:

Code changes have been tested against the Discord API, or there are no code changes
I know how to update typings and have done so, or typings don't need updating
This PR changes the library's interface (methods or parameters added)

vercel · 2023-08-20T13:58:21Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
discord-js	❌ Failed (Inspect)			Sep 2, 2023 9:54am
discord-js-guide	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 2, 2023 9:54am

codecov · 2023-08-20T14:00:17Z

Codecov Report

Merging #9787 (2ed306b) into main (23a6424) will increase coverage by 0.12%.
The diff coverage is 96.42%.

@@            Coverage Diff             @@
##             main    #9787      +/-   ##
==========================================
+ Coverage   59.91%   60.04%   +0.12%     
==========================================
  Files         235      235              
  Lines       15963    16017      +54     
  Branches     1210     1213       +3     
==========================================
+ Hits         9565     9617      +52     
- Misses       6353     6355       +2     
  Partials       45       45

Flag	Coverage Δ
brokers	`63.16% <ø> (ø)`
builders	`98.69% <ø> (ø)`
collection	`99.87% <ø> (ø)`
formatters	`99.45% <ø> (ø)`
guide	`0.00% <ø> (ø)`
next	`∅ <ø> (∅)`
proxy	`76.31% <ø> (ø)`
rest	`92.77% <96.42%> (+0.08%)`	⬆️
util	`70.70% <ø> (ø)`
utilities	`100.00% <ø> (ø)`
voice	`63.53% <ø> (ø)`
website	`0.00% <ø> (ø)`
ws	`52.45% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
packages/rest/src/lib/utils/utils.ts	`93.67% <87.50%> (-0.70%)`	⬇️
packages/rest/src/lib/CDN.ts	`96.35% <100.00%> (+0.34%)`	⬆️
packages/rest/src/lib/utils/constants.ts	`100.00% <100.00%> (ø)`

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

github-actions · 2023-08-20T15:58:37Z

⚡️ Lighthouse report for the changes in this PR:

Category	Score
🟢 Performance	92
🟢 Accessibility	96
🟢 Best practices	100
🟠 SEO	67
🔴 PWA	33

Lighthouse ran on https://discord-js-git-feat-emoji-size-discordjs.vercel.app/

packages/rest/src/lib/CDN.ts

* feat(CDN): support emoji size * refactor: try to warn in all environments * feat: add prefix * refactor: better feedback message --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@discordjs/rest](https://discord.js.org) ([source](https://github.com/discordjs/discord.js)) | dependencies | minor | [`2.0.1` -> `2.2.0`](https://renovatebot.com/diffs/npm/@discordjs%2frest/2.0.1/2.2.0) | --- ### Release Notes <details> <summary>discordjs/discord.js (@discordjs/rest)</summary> ### [`v2.2.0`](https://github.com/discordjs/discord.js/blob/HEAD/packages/rest/CHANGELOG.md#discordjsrest220---2023-11-17) [Compare Source](https://github.com/discordjs/discord.js/compare/@discordjs/[email protected]...@discordjs/[email protected]) #### Bug Fixes - Minify mainlib docs json ([#9963](discordjs/discord.js#9963)) ([4b88306](discordjs/discord.js@4b88306)) #### Features - Present x-ratelimit-scope for 429s hit ([#9973](discordjs/discord.js#9973)) ([6df233d](discordjs/discord.js@6df233d)) #### Typings - Use wrapper utilities ([#9945](discordjs/discord.js#9945)) ([4bc1dae](discordjs/discord.js@4bc1dae)) ### [`v2.1.0`](https://github.com/discordjs/discord.js/blob/HEAD/packages/rest/CHANGELOG.md#discordjsrest210---2023-11-12) [Compare Source](https://github.com/discordjs/discord.js/compare/@discordjs/[email protected]...@discordjs/[email protected]) #### Bug Fixes - **REST:** Strip webhook tokens ([#9723](discordjs/discord.js#9723)) ([cf49f40](discordjs/discord.js@cf49f40)) #### Documentation - Fix "its" typo ([#9825](discordjs/discord.js#9825)) ([c50809e](discordjs/discord.js@c50809e)) - **create-discord-bot:** Support bun in create-discord-bot ([#9798](discordjs/discord.js#9798)) ([7157748](discordjs/discord.js@7157748)) #### Features - Expose Retry-After and sublimit timeouts in RatelimitData ([#9864](discordjs/discord.js#9864)) ([81e7866](discordjs/discord.js@81e7866)) - **CDN:** Support emoji size ([#9787](discordjs/discord.js#9787)) ([778df45](discordjs/discord.js@778df45)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.vylpes.xyz/External/card-drop/pulls/101 Reviewed-by: Vylpes <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@discordjs/rest](https://discord.js.org) ([source](https://github.com/discordjs/discord.js)) | dependencies | minor | [`2.0.1` -> `2.2.0`](https://renovatebot.com/diffs/npm/@discordjs%2frest/2.0.1/2.2.0) | --- ### Release Notes <details> <summary>discordjs/discord.js (@discordjs/rest)</summary> ### [`v2.2.0`](https://github.com/discordjs/discord.js/blob/HEAD/packages/rest/CHANGELOG.md#discordjsrest220---2023-11-17) [Compare Source](https://github.com/discordjs/discord.js/compare/@discordjs/[email protected]...@discordjs/[email protected]) #### Bug Fixes - Minify mainlib docs json ([#9963](discordjs/discord.js#9963)) ([4b88306](discordjs/discord.js@4b88306)) #### Features - Present x-ratelimit-scope for 429s hit ([#9973](discordjs/discord.js#9973)) ([6df233d](discordjs/discord.js@6df233d)) #### Typings - Use wrapper utilities ([#9945](discordjs/discord.js#9945)) ([4bc1dae](discordjs/discord.js@4bc1dae)) ### [`v2.1.0`](https://github.com/discordjs/discord.js/blob/HEAD/packages/rest/CHANGELOG.md#discordjsrest210---2023-11-12) [Compare Source](https://github.com/discordjs/discord.js/compare/@discordjs/[email protected]...@discordjs/[email protected]) #### Bug Fixes - **REST:** Strip webhook tokens ([#9723](discordjs/discord.js#9723)) ([cf49f40](discordjs/discord.js@cf49f40)) #### Documentation - Fix "its" typo ([#9825](discordjs/discord.js#9825)) ([c50809e](discordjs/discord.js@c50809e)) - **create-discord-bot:** Support bun in create-discord-bot ([#9798](discordjs/discord.js#9798)) ([7157748](discordjs/discord.js@7157748)) #### Features - Expose Retry-After and sublimit timeouts in RatelimitData ([#9864](discordjs/discord.js#9864)) ([81e7866](discordjs/discord.js@81e7866)) - **CDN:** Support emoji size ([#9787](discordjs/discord.js#9787)) ([778df45](discordjs/discord.js@778df45)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/vylbot-app/pulls/375 Reviewed-by: Vylpes <[email protected]> Co-authored-by: Renovate Bot <[email protected]> Co-committed-by: Renovate Bot <[email protected]>

feat(CDN): support emoji size

5374fbf

Jiralite added api support semver:minor packages:rest labels Aug 20, 2023

Jiralite added this to the rest 2.1.0 milestone Aug 20, 2023

Jiralite requested a review from a team as a code owner August 20, 2023 13:58

Jiralite requested review from ckohen, vladfrangu, iCrawl, kyranet and didinele August 20, 2023 13:58

didinele approved these changes Aug 20, 2023

View reviewed changes

SpaceEEC approved these changes Aug 20, 2023

View reviewed changes

sdanialraza approved these changes Aug 20, 2023

View reviewed changes

Jiralite mentioned this pull request Aug 20, 2023

feat(Emoji): Add imageURL() #9788

Merged

Jiralite marked this pull request as draft August 20, 2023 15:31

refactor: try to warn in all environments

d2d6c2e

Jiralite force-pushed the feat/emoji-size branch from 02f6def to d2d6c2e Compare August 20, 2023 15:59

feat: add prefix

850c5ee

Jiralite marked this pull request as ready for review August 20, 2023 16:14

ckohen requested changes Sep 2, 2023

View reviewed changes

packages/rest/src/lib/CDN.ts Outdated Show resolved Hide resolved

refactor: better feedback message

97ac081

Jiralite requested a review from ckohen September 2, 2023 09:30

ckohen approved these changes Sep 2, 2023

View reviewed changes

Merge branch 'main' into feat/emoji-size

2ed306b

vercel bot had a problem deploying to Preview – discord-js September 2, 2023 09:54 Failure

vercel bot deployed to Preview – discord-js-guide September 2, 2023 09:54 View deployment

kodiakhq bot merged commit 778df45 into main Sep 2, 2023
21 checks passed

kodiakhq bot deleted the feat/emoji-size branch September 2, 2023 09:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(CDN): Support emoji size #9787

feat(CDN): Support emoji size #9787

Jiralite commented Aug 20, 2023 •

edited

Loading

vercel bot commented Aug 20, 2023 •

edited

Loading

codecov bot commented Aug 20, 2023 •

edited

Loading

github-actions bot commented Aug 20, 2023 •

edited

Loading

feat(CDN): Support emoji size #9787

feat(CDN): Support emoji size #9787

Conversation

Jiralite commented Aug 20, 2023 • edited Loading

vercel bot commented Aug 20, 2023 • edited Loading

codecov bot commented Aug 20, 2023 • edited Loading

Codecov Report

github-actions bot commented Aug 20, 2023 • edited Loading

Jiralite commented Aug 20, 2023 •

edited

Loading

vercel bot commented Aug 20, 2023 •

edited

Loading

codecov bot commented Aug 20, 2023 •

edited

Loading

github-actions bot commented Aug 20, 2023 •

edited

Loading