-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(BaseClient): Prevent user agent mutation #9425
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-git-fix-appending-user-agent-discordjs.vercel.app/ |
Codecov Report
@@ Coverage Diff @@
## main #9425 +/- ##
==========================================
- Coverage 59.30% 59.26% -0.04%
==========================================
Files 222 222
Lines 14630 14581 -49
Branches 1257 1251 -6
==========================================
- Hits 8676 8642 -34
+ Misses 5914 5899 -15
Partials 40 40
Flags with carried forward coverage won't be shown. Click here to find out more. see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Please describe the changes this PR makes and why it should be merged:
Resolves #9421 by removing the mutation (bad bad bad). We instead make use of the spread operator.
Status and versioning classification: