feat: Voice Channel Send Effects#9288
Merged
Jiralite merged 14 commits intodiscordjs:feat/v-c-s-efrom Jun 3, 2024
Jiralite:feat/voice-effects
Merged
feat: Voice Channel Send Effects#9288Jiralite merged 14 commits intodiscordjs:feat/v-c-s-efrom Jiralite:feat/voice-effects
Jiralite merged 14 commits intodiscordjs:feat/v-c-s-efrom
Jiralite:feat/voice-effects
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Jiralite is attempting to deploy a commit to the discordjs Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
requested review from
SpaceEEC,
iCrawl,
kyranet and
vladfrangu
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-git-fork-jiralite-feat-voice-effects-discordjs.vercel.app/ |
Contributor
|
may you add channel getter? |
Jiralite
requested review from
SpaceEEC,
iCrawl,
kyranet and
vladfrangu
and removed request for
a team,
SpaceEEC,
iCrawl,
kyranet and
vladfrangu
Jiralite
added a commit
that referenced
this pull request
Oct 9, 2024
Jiralite
added a commit
that referenced
this pull request
Oct 9, 2024
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 14, 2024
* feat: Voice Channel Send Effects (#9288) * feat: add soundboard fields * chore: address TODO * docs: volume is a closed interval * types: use `GatewayVoiceChannelEffectSendDispatchData` * refactor: prefer getting from cache * fix: correctly access cache Co-authored-by: Danial Raza <danialrazafb@gmail.com> --------- Co-authored-by: Danial Raza <danialrazafb@gmail.com>
Jiralite
added a commit
that referenced
this pull request
Nov 15, 2024
* feat: Voice Channel Send Effects (#9288) * feat: add soundboard fields * chore: address TODO * docs: volume is a closed interval * types: use `GatewayVoiceChannelEffectSendDispatchData` * refactor: prefer getting from cache * fix: correctly access cache Co-authored-by: Danial Raza <danialrazafb@gmail.com> --------- Co-authored-by: Danial Raza <danialrazafb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
VoiceChannelEffectSendevent discord-api-types#739Status and versioning classification: