-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Voice): implement support for @discordjs/voice #5402
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advaith1
reviewed
Mar 14, 2021
vladfrangu
requested changes
Mar 14, 2021
I'm converting this back to a draft as I want to fix discordjs/voice#78 before adapters are added directly to Discord.js. |
vladfrangu
reviewed
Mar 18, 2021
vladfrangu
approved these changes
Apr 3, 2021
Converting to a draft, need to update the adapter as well as deprecate current Discord.js voice code. |
amishshah
force-pushed
the
feat/voice-adapters
branch
from
June 8, 2021 11:59
33dc503
to
e980948
Compare
kyranet
reviewed
Jun 8, 2021
SpaceEEC
previously requested changes
Jun 8, 2021
1 task
1 task
1 task
1 task
This was referenced Jun 9, 2021
Closed
This was referenced Jun 9, 2021
This was referenced Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR allows for creating adapters that can be used by @discordjs/voice. This PR also removes the existing voice codebase as it will no longer be maintained.
The only voice code that will remain in discord.js will be voice states, which aren't specifically part of the Discord Voice API.
What is @discordjs/voice?
@discordjs/voice is a stand-alone library that implements the Discord Voice API. It aims to offer better stability, performance, and scalability than the existing voice client within Discord.js v12.
Discord.js v13 will remove support for the Voice API, and this functionality can be replaced by installing @discordjs/voice (
npm install @discordjs/voice
) as an add-on.Example usage:
How do I update my code to use @discordjs/voice?
@discordjs/voice is nearing its release. If you want to get a head start on migrating your voice code to the library, you should take a look at this PR which shows how to create a music bot with @discordjs/voice and TypeScript - discordjs/voice#107
Status and versioning classification: