fix(Message): Ensure channel is defined for clean content #10681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
channel
may benull
and thus when passing tocleanContent()
, a crash will occur on valid types. This is reproducible in 2 (known) ways:cleanContent
on a forwarded message from a guild one is not incleanContent
on a interaction's response message from a guild one is not inStack trace:
In both cases, a message is constructed with a channel id that is not cached, so that will result in
null
being sent to thecleanContent()
. This will resolve #10679—seems they're calling.toJSON()
somewhere to achieve this orcleanContent
directly.Status and versioning classification: