docs: add note about idempotence to role add/remove routes #10586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
almeidx
changed the title
didinele
approved these changes
Nov 1, 2024
vladfrangu
approved these changes
Nov 4, 2024
almostSouji
force-pushed
the
docs-role-idempotence
branch
from
23130bc to
12e169f
Compare
Jiralite
approved these changes
Nov 5, 2024
Jiralite
pushed a commit
that referenced
this pull request
Nov 5, 2024
* chore(docs): Add note about idempotence to role add/remove routes * chore: remove trailing spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
It's not clear to users that the behaviour of #add and #remove calls changes based on if a singular or multiple roles are supplied. We should explicitly note that, as it can lead to issues (for example when multiple role-state bots interact and use patch calls).
Status and versioning classification: