Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ThreadChannel): Address parameter type on fetchOwner() #10579

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ThreadChannel): Address parameter type on fetchOwner() #10579

wants to merge 1 commit into from
+13 −3

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Resolves #10578.

In addition, this method cannot return null, so the typings and documentation had null removed (remnant of #10421).

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Oct 24, 2024
@Jiralite Jiralite requested a review from a team as a code owner October 24, 2024 23:14
@vercel Vercel
Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Oct 24, 2024 11:14pm
discord-js-guide ⬜️ Ignored (Inspect) Oct 24, 2024 11:14pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@didinele didinele didinele approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
packages:discord.js semver:patch threads
Projects
discord.js
Status: Todo
Milestone
discord.js 15.0.0
Development

Successfully merging this pull request may close these issues.

Wrong fetch options interface - ThreadChannel#fetchOwner()
3 participants
@Jiralite @vladfrangu @didinele