Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: fix several issues with /ws incorporation #10556

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Oct 12, 2024

Please describe the changes this PR makes and why it should be merged:

#10420 introduced some bugs that get fixed with this:

  • Client#shard registers listeners on Client#ws so it needs to be initialized after Client#ws
  • Client#ping was NaN before the first heartbeat from the gateway was received, now it'll return null instead
  • erroneous rebase of refactor!: fully integrate /ws into mainlib #10420 caused deprecated DiscordjsErrorCodes to reappear in src/errors/ErrorCodes.js

Fixes #10555.

BREAKING CHANGE: Client#ping is nullable now

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@Qjuh Qjuh requested a review from a team as a code owner October 12, 2024 17:33
Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 11:46pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 11:46pm

@Qjuh Qjuh changed the title fix!: several issues with /ws incorporation refactor!: several issues with /ws incorporation Oct 12, 2024
@Qjuh Qjuh changed the title refactor!: several issues with /ws incorporation refactor!: fix several issues with /ws incorporation Oct 12, 2024
@Jiralite Jiralite removed the blocked label Oct 18, 2024
@Jiralite Jiralite merged commit 93b84ae into discordjs:main Oct 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

References to WebSocketManager in ShardClientUtil before declaration in Client
5 participants