refactor!: fix several issues with /ws incorporation #10556
Merged
+11
−93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
#10420 introduced some bugs that get fixed with this:
Client#shard
registers listeners onClient#ws
so it needs to be initialized afterClient#ws
Client#ping
wasNaN
before the first heartbeat from the gateway was received, now it'll returnnull
insteadsrc/errors/ErrorCodes.js
Fixes #10555.
BREAKING CHANGE:
Client#ping
is nullable nowStatus and versioning classification: