chore: make semver:major block kodiak #10548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
vladfrangu
requested review from
a team,
kyranet and
SpaceEEC
and removed request for
a team
Jiralite
approved these changes
Oct 10, 2024
There was a problem hiding this comment.
Whilst I believe pull requests should not be approved without all the desires we want, I believe it is sensible anyway to disallow automatically merging something that is not backwards compatible. Just in case. So ultimately, I'm more leaning towards accepting this.
kyranet
approved these changes
Oct 11, 2024
didinele
approved these changes
Oct 11, 2024
iCrawl
approved these changes
Oct 16, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10548 +/- ##
==========================================
+ Coverage 38.00% 38.03% +0.02%
==========================================
Files 239 239
Lines 15488 15464 -24
Branches 1367 1353 -14
==========================================
- Hits 5886 5881 -5
+ Misses 9587 9568 -19
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This is realistically a proposal and can be closed if we don't do it, but as we tend to want to merge major PRs manually (to ensure the commit has changelog entry correct), I think we should skip adding in an extra label.
Status and versioning classification: