-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make semver:major block kodiak #10548
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whilst I believe pull requests should not be approved without all the desires we want, I believe it is sensible anyway to disallow automatically merging something that is not backwards compatible. Just in case. So ultimately, I'm more leaning towards accepting this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10548 +/- ##
==========================================
+ Coverage 38.00% 38.03% +0.02%
==========================================
Files 239 239
Lines 15488 15464 -24
Branches 1367 1353 -14
==========================================
- Hits 5886 5881 -5
+ Misses 9587 9568 -19
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please describe the changes this PR makes and why it should be merged:
This is realistically a proposal and can be closed if we don't do it, but as we tend to want to merge major PRs manually (to ensure the commit has changelog entry correct), I think we should skip adding in an extra label.
Status and versioning classification: