Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MessagePayload): crash when resolving body #10454

Merged
merged 2 commits into from
Aug 20, 2024
Merged

fix(MessagePayload): crash when resolving body #10454

merged 2 commits into from
Aug 20, 2024

Conversation

N1ckPro
Copy link
Contributor

@N1ckPro N1ckPro commented Aug 20, 2024 •
edited by almeidx
Loading

Please describe the changes this PR makes and why it should be merged:
this.client is undefined meaning this code currently crashes

Regression from #10381

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@N1ckPro N1ckPro requested a review from a team as a code owner August 20, 2024 13:28
@vercel Vercel
Copy link

vercel bot commented Aug 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 3:59pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 3:59pm

@almeidx almeidx added this to the discord.js 14.16 milestone Aug 20, 2024
@JMTK
Copy link
Contributor

JMTK commented Aug 20, 2024

Good catch, thank you for fixing that!

@kodiakhq kodiakhq bot merged commit dd795da into discordjs:main Aug 20, 2024
7 checks passed
@N1ckPro N1ckPro deleted the fix/message-payload-error branch August 20, 2024 16:05
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Sep 9, 2024
@N1ckPro @kodiakhq @nyapat
fix(MessagePayload): crash when resolving body (discordjs#10454)
f1df3bb 
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@Mocksybren Mocksybren mentioned this pull request Sep 24, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 24, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 24, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Sep 24, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Sep 24, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 24, 2024
Open
@JajoScript JajoScript mentioned this pull request Sep 24, 2024
Merged
@Ashpan Ashpan mentioned this pull request Sep 24, 2024
Open
This was referenced Sep 24, 2024
Open
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 25, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 26, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 26, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Sep 26, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 26, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 27, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 27, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Sep 27, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 27, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 28, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 28, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Sep 28, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 28, 2024
Open
@ReiseArnor ReiseArnor mentioned this pull request Sep 29, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 30, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Oct 3, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Oct 3, 2024
Open
@Azzraya Azzraya mentioned this pull request Oct 3, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Oct 4, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Oct 4, 2024
Open
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Oct 4, 2024
@N1ckPro @kodiakhq @nyapat
fix(MessagePayload): crash when resolving body (discordjs#10454)
70f7e85 
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@IzzyDotExe IzzyDotExe mentioned this pull request Oct 4, 2024
Merged
@Azzraya Azzraya mentioned this pull request Oct 8, 2024
Open
This was referenced Oct 13, 2024
Open
Open
@jshuntley jshuntley mentioned this pull request Oct 24, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Oct 25, 2024
Open
@lkeff lkeff mentioned this pull request Oct 25, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Oct 27, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Oct 27, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@almeidx almeidx almeidx approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:discord.js regression semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js 14.16
Development

Successfully merging this pull request may close these issues.
5 participants
@N1ckPro @JMTK @vladfrangu @SpaceEEC @almeidx