Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VoiceState): add methods for fetching voice state #10442

Merged
merged 13 commits into from
Aug 20, 2024

Conversation

imnaiyar
Copy link
Contributor

@imnaiyar imnaiyar commented Aug 12, 2024

Please describe the changes this PR makes and why it should be merged:

Depends on

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@imnaiyar imnaiyar requested a review from a team as a code owner August 12, 2024 16:08
Copy link

vercel bot commented Aug 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 9:56am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 9:56am

Copy link
Contributor

@sdanialraza sdanialraza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GatewayVoiceState is now unused and can be removed from here

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
packages/discord.js/src/managers/VoiceStateManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/VoiceStateManager.js Outdated Show resolved Hide resolved
packages/core/src/api/voice.ts Outdated Show resolved Hide resolved
packages/core/src/api/guild.ts Outdated Show resolved Hide resolved
@jaw0r3k
Copy link
Contributor

jaw0r3k commented Aug 12, 2024

You forgot to handle @me as a user parameter (docs reference)

packages/core/src/api/guild.ts Outdated Show resolved Hide resolved
packages/core/src/api/guild.ts Show resolved Hide resolved
@almeidx almeidx removed the blocked label Aug 20, 2024
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Oct 4, 2024
* feat(VoiceState): add methods for fetching voice state

* fix: links to new methods

* chore: remove unused import

* chore: use member id

* chore: requested changes

* chore: '@me' as fetch param

* chore: add ediUserVoiceState return type

* refactor: redirect function calls to VoiceAPI

---------

Co-authored-by: Almeida <[email protected]>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

9 participants