Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add subtext formatter #10400

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

sdanialraza
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
Adds a formatter for the new subtext markdown feature which can be found here under "Organizational Text Formatting"

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

Copy link

vercel bot commented Jul 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 10:17am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 10:17am

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.55%. Comparing base (efa16a6) to head (bc15654).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10400      +/-   ##
==========================================
+ Coverage   50.52%   50.55%   +0.02%     
==========================================
  Files         228      228              
  Lines       20705    20715      +10     
  Branches     1252     1253       +1     
==========================================
+ Hits        10462    10472      +10     
  Misses      10199    10199              
  Partials       44       44              
Flag Coverage Δ
builders 95.78% <ø> (ø)
formatters 99.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jiralite Jiralite added this to the formatters 0.5.0 milestone Jul 24, 2024
@kodiakhq kodiakhq bot merged commit fcd35ea into discordjs:main Jul 24, 2024
7 checks passed
@sdanialraza sdanialraza deleted the feat/add-subtext-formatter branch July 24, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants