Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: application emojis #10399

Merged
merged 4 commits into from
Aug 20, 2024
Merged

feat: application emojis #10399

merged 4 commits into from
Aug 20, 2024

Conversation

sdanialraza
Copy link
Contributor

@sdanialraza sdanialraza commented Jul 20, 2024 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:
Adds application emojis support for core and discord.js and resolves #10396

Depends on changes from:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel Vercel
Copy link

vercel bot commented Jul 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 9:27am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Aug 20, 2024 9:27am

@Jiralite Jiralite self-requested a review July 21, 2024 18:35
@Glazelf Glazelf mentioned this pull request Jul 22, 2024
Closed
@sdanialraza sdanialraza mentioned this pull request Jul 22, 2024
Merged
@sdanialraza sdanialraza marked this pull request as ready for review August 1, 2024 13:42
@sdanialraza sdanialraza requested a review from a team as a code owner August 1, 2024 13:42
@vladfrangu vladfrangu added this to the discord.js 14.16 milestone Aug 4, 2024
@kodiakhq kodiakhq bot merged commit 5d92525 into discordjs:main Aug 20, 2024
7 checks passed
@AlexEKinney AlexEKinney mentioned this pull request Sep 26, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 26, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Sep 26, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 26, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 27, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 27, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Sep 27, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 27, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 28, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 28, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Sep 28, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 28, 2024
Open
@ReiseArnor ReiseArnor mentioned this pull request Sep 29, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 30, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Oct 3, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Oct 3, 2024
Open
@Azzraya Azzraya mentioned this pull request Oct 3, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Oct 4, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Oct 4, 2024
Open
nyapat pushed a commit to nyapat/discord.js that referenced this pull request Oct 4, 2024
@sdanialraza @kodiakhq @nyapat
feat: application emojis (discordjs#10399)
54ad04c 
* feat: application emojis

* chore: requested changes

---------

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@IzzyDotExe IzzyDotExe mentioned this pull request Oct 4, 2024
Merged
@Azzraya Azzraya mentioned this pull request Oct 8, 2024
Open
This was referenced Oct 13, 2024
Open
Open
@jshuntley jshuntley mentioned this pull request Oct 24, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Oct 25, 2024
Open
@lkeff lkeff mentioned this pull request Oct 25, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Oct 27, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Oct 27, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@Jiralite Jiralite Awaiting requested review from Jiralite

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:core packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js 14.16
Development

Successfully merging this pull request may close these issues.

Application Emojis
4 participants
@sdanialraza @vladfrangu @kyranet @SpaceEEC