-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Consistent debug log spacing #10349
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiralite
requested review from
vladfrangu,
iCrawl,
didinele,
kyranet,
suneettipirneni and
SpaceEEC
June 13, 2024 13:54
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
vladfrangu
approved these changes
Jun 13, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10349 +/- ##
==========================================
+ Coverage 63.01% 63.08% +0.07%
==========================================
Files 131 132 +1
Lines 16326 16333 +7
Branches 1139 1143 +4
==========================================
+ Hits 10288 10304 +16
+ Misses 5993 5984 -9
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
didinele
approved these changes
Jun 13, 2024
Syjalo
suggested changes
Jun 13, 2024
Co-Authored-By: Synbulat Biishev <[email protected]>
Jiralite
force-pushed
the
fix/debug-spacing
branch
from
June 13, 2024 15:54
3f57d4e
to
c0f3428
Compare
This was referenced Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
In discord.js, indentation of debug log messages were inconsistent with @discordjs/ws. This brings discord.js into same implementation as @discordjs/ws.
Before
After
Status and versioning classification: