Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PollBuilder #10324

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

feat: PollBuilder #10324

wants to merge 26 commits into from

Conversation

TAEMBO
Copy link
Contributor

@TAEMBO TAEMBO commented Jun 4, 2024

Please describe the changes this PR makes and why it should be merged:
Adds the PollBuilder class that creates API-compatible JSON data for sending polls.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@TAEMBO TAEMBO requested a review from a team as a code owner June 4, 2024 08:24
Copy link

vercel bot commented Jun 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2024 9:36pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jun 27, 2024 9:36pm

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.96%. Comparing base (9c76bbe) to head (c97b087).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10324      +/-   ##
==========================================
+ Coverage   50.37%   50.96%   +0.59%     
==========================================
  Files         228      230       +2     
  Lines       20641    20891     +250     
  Branches     1240     1263      +23     
==========================================
+ Hits        10397    10647     +250     
  Misses      10199    10199              
  Partials       45       45              
Flag Coverage Δ
builders 96.16% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TAEMBO TAEMBO requested a review from Jiralite June 4, 2024 18:28
@TAEMBO TAEMBO requested a review from almeidx June 5, 2024 17:18
Jiralite
Jiralite previously approved these changes Jun 6, 2024
@TAEMBO TAEMBO marked this pull request as ready for review June 22, 2024 04:34
@TAEMBO TAEMBO requested a review from a team as a code owner June 22, 2024 04:34
@TAEMBO TAEMBO requested a review from SpaceEEC June 22, 2024 04:34
@TAEMBO
Copy link
Contributor Author

TAEMBO commented Jun 26, 2024

@Jiralite Jiralite removed this from the builders 1.9.0 milestone Jun 27, 2024
Jiralite

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

None yet

3 participants