feat(builders): update to @sapphire/shapeshift v4 #10291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10291 +/- ##
==========================================
+ Coverage 50.10% 50.23% +0.12%
==========================================
Files 228 228
Lines 20533 20583 +50
Branches 1236 1236
==========================================
+ Hits 10289 10339 +50
Misses 10199 10199
Partials 45 45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
favna
force-pushed
the
refactor/update-to-shapeshift-v4
branch
from
5dc221c
to
52c8b74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This updates the Shapeshift dependency and related code to @sapphire/shapeshift v4. This does not yet add custom messages to all the functions, which needs further discussion on what to set where. In a way this PR can also be a jumping-off point for @Qjuh. This PR also has a relation to #10117.
While this concerns a new major version of Shapeshift, there are no user-facing breaking changes to @discordjs/builders in this version that would incur the need for a new major version of @discordjs/builders.
Status and versioning classification: