Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Message): properly compare attachments and embeds #10282

Merged
merged 4 commits into from
May 24, 2024
Merged

fix(Message): properly compare attachments and embeds #10282

merged 4 commits into from
May 24, 2024

Conversation

sdanialraza
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This properly compares attachments and embeds properties instead of just comparing the lengths.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@sdanialraza sdanialraza requested a review from a team as a code owner May 18, 2024 08:27
@vercel Vercel
Copy link

vercel bot commented May 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 2:15pm
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 2:15pm

@Jiralite Jiralite added this to the discord.js 14.15.3 milestone May 18, 2024
Jiralite
Jiralite approved these changes May 19, 2024
View reviewed changes
packages/discord.js/src/structures/Message.js Outdated Show resolved Hide resolved
@sdanialraza sdanialraza requested a review from kyranet May 24, 2024 13:03
@kodiakhq kodiakhq bot merged commit a468ae8 into discordjs:main May 24, 2024
6 checks passed
@sdanialraza sdanialraza deleted the fix/properly-compare-attachments-embeds branch May 24, 2024 14:20
@Azzraya Azzraya mentioned this pull request Jun 23, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Jun 24, 2024
Open
@yaasiin-ayeva yaasiin-ayeva mentioned this pull request Jun 24, 2024
Merged
This was referenced Jun 24, 2024
Merged
Merged
@ciscoderp ciscoderp mentioned this pull request Jun 24, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Jun 24, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 19, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 19, 2024
Open
@mezotv mezotv mentioned this pull request Aug 19, 2024
Closed
@HowlingArcher HowlingArcher mentioned this pull request Aug 20, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 20, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 20, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 20, 2024
Open
@Jcrandall541 Jcrandall541 mentioned this pull request Aug 21, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 21, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 21, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 21, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 21, 2024
Open
@Jcrandall541 Jcrandall541 mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 22, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 22, 2024
Open
@whizbangpop whizbangpop mentioned this pull request Aug 22, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 22, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 22, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Aug 28, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Aug 28, 2024
Open
@Azzraya Azzraya mentioned this pull request Aug 28, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Aug 29, 2024
Open
This was referenced Aug 30, 2024
Open
Open
@jshuntley jshuntley mentioned this pull request Sep 1, 2024
Open
@HowlingArcher HowlingArcher mentioned this pull request Sep 2, 2024
Open
@jshuntley jshuntley mentioned this pull request Sep 2, 2024
Open
@AlexEKinney AlexEKinney mentioned this pull request Sep 2, 2024
Open
@WhyAydan WhyAydan mentioned this pull request Sep 2, 2024
Open
@Azzraya Azzraya mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

@Jiralite Jiralite Jiralite approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:discord.js semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js 14.15.3
Development

Successfully merging this pull request may close these issues.
4 participants
@sdanialraza @vladfrangu @kyranet @Jiralite