-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ThreadMemberManager): #remove accepts UserResolvable #10000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Jiralite
reviewed
Nov 25, 2023
vladfrangu
approved these changes
Nov 30, 2023
iCrawl
approved these changes
Nov 30, 2023
Jiralite
approved these changes
Dec 1, 2023
cobaltt7
added a commit
to scratchaddons-community/scradd
that referenced
this pull request
Dec 19, 2023
Signed-off-by: RedGuy12 <[email protected]>
This was referenced Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Adds the ability to pass a resolvable to
ThreadMemberManager#remove
, in keeping with other manager functions.Note that this deliberately accepts a UserResolvable to pass to
UserManager#resolveId
, rather than a ThreadMemberResolvable to pass toThreadMemberManager#resolveId
. There are two reasons for this:UserManager#resolveId
accepts a ThreadMember as an argument anyway;ThreadMemberManager#resolveId
always returns null. (ref)The new argument type is a superset of the old one, and so this is suitable for semver:patch.
Discussion:
ThreadMemberManager#add
and#remove
accept a reason argument, but neither API endpoint supports the X-Audit-Log-Reason header, as neither event is loggable. I've left them there, as removing the arguments would technically be a breaking change, but these should probably be removed at some point.Status and versioning classification: