-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nanite changes #8141
Draft
RikuTheKiller
wants to merge
23
commits into
discordia-space:master
Choose a base branch
from
RikuTheKiller:repair_nanite_rework
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Nanite changes #8141
RikuTheKiller
wants to merge
23
commits into
discordia-space:master
from
RikuTheKiller:repair_nanite_rework
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Makes nanites do things a lot differently. Especially affects repair nanites.
Nanites will now work when ingested via moving into the bloodstream on their own. This means nanites that previously only worked on non-fbps work on fbps and ones that only worked on fbps work on non-fbps. You can also use them as pills now, them being restricted to blood was undocumented as well, but now it's not as much of an issue.
Repair nanites, now "mechanites" no longer work based on a convoluted system of adding metals together with the nanites in specific ratios to fix different types of wounds... even writing this makes my brain hurt. Not to mention the total lack of in-game documentation.
They instead work like other wound healing chemicals do, however, they also heal all prosthetic limbs by a total of 5 brute and burn that is shared across all damaged prosthetic limbs.
I've also improved a few descriptions in slight ways and removed the weird fbp subtype as it's no longer needed and caused some annoying side-effects, such as them not being affected by metabolism modifiers. They also no longer bypass the need to be in the bloodstream, as nanites can now simply navigate to the bloodstream from the stomach.
Also, the nanites that were previously subtyped from uncapped are now subtyped like the rest of the nanites, since they no longer need special snowflake code to work on ingest. (From my testing, that wasn't working anyways.)
Why It's Good For The Game
It makes undocumented shitcode chems actually good. I bet others have been confused by nanites not working as expected as well and this PR aims to address all of that.
Testing
Basic testing done, everything worked as expected. Might need a TM or might not.
Changelog
🆑
balance: All nanites work properly now, whether you take them via ingestion or injection. Repair nanites, now "mechanites", can affect non-fbps and don't require a convoluted mess of metal reagents to function. They also slowly heal prosthetic limbs.
/:cl: