Don't let users Tab to other elements when dragging
#17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would love to get your thoughts on this @faultyserver @mzlock Thanks a ton for this amazing library |
|
@ayy-bc I wonder if it would be better to create a container component that developers could wrap around their drag and drop container. Perhaps using the The hook would have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When drag and drop mode is turned on (i.e an item is being dragged ~
isDragging()is true) ensure that users cannot tab to other elements on the screen.Note: I was thinking of adding tests for this but saw that we didn't have any testing library for react-dnd-accessible-backend. Is there any preference? I was thinking of installing Jest for unit tests but wanted to make sure that its okay before making any changes on that. I can start a follow-up PR to add some tests around some of these things if we can finalize a library to use.