Support for cropping the original image before rescaling#168
Open
Coffelius wants to merge 3 commits intodiscord:masterfrom
Open
Support for cropping the original image before rescaling#168Coffelius wants to merge 3 commits intodiscord:masterfrom
Coffelius wants to merge 3 commits intodiscord:masterfrom
Conversation
|
Hello, how would the usage be? how can i crop & use transform? can you show me example code please? thanks |
|
oh nevermind, im an idiot, its in the image options |
|
damn, unfortunately it seems like it breaks transparent gifs, sigh, i can never find a way to resize at a good speed like discord does. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I understand that this feature may not make much sense to the project maintainers since it addresses a specific use case I have, where the images to be rescaled may originate from a frontend component allowing the user to select a cropping rectangle on an uploaded photo.
However, I am sharing the PR in case someone else might be interested in a similar feature or if an experienced developer in the community might spot any flaws in the implementation that I have missed. In any case, if this PR is not appropriate, I apologize in advance and thank you very much for this excellent project.