Allow more than 1 action to be registered per automod rule #2687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an issue where you cannot register more than 1 automod rule due to the limit and length of the rules being inverted (This also has the side effect of allowing you to attempt to register 0 actions, resulting in a 50035 invalid body error)
quinchs
approved these changes
Jun 11, 2023
Member
quinchs
left a comment
quinchs
left a comment
There was a problem hiding this comment.
@Misha-133 you have to test your code works, bugs like this shouldn't get included into dev..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #2686
Swaps the 1st and 2nd parameter around to allow more than 1 action to be registered per rule (And prevents any attempts to register 0 actions per rule)