Added a method for sending silent audio frames on OpusEncodeStream #2668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have removed the changes to the project file, so the note can be ignored. |
quinchs
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a method on OpusEncodeStream, that sends 5 frames of silence to prevent audio interpolation errors when pausing audio input, or stopping the audio stream as per the Discord API Reference recommendation.
Currently requires the user to manually call it on breaks in audio output (pause/stop).
Note:
The changes to Discord.Net.Interactions.csproj are due to warnings that appear from deprecated classes and properties (warning CS0618), which gets turned into errors as set in the project settings, which will then not allow me to compile the project. Therefore I have just set it to ignore this specific warning.