ModifyAsync Attachments Bug Fix #2236 (#2742)

DeclanFrampton · Misha-133 · quinchs · web-flow · commit 0c120796c433 · 2023-08-10T16:43:09.000+03:00
* ModifyAsync Attatchment Bug Fix

* Resolved UploadWebhookFileParams Bug when passing through null attatchment obj.

* Grammar.

* Update src/Discord.Net.Rest/Entities/Interactions/InteractionHelper.cs

Co-authored-by: Quin Lynch &lt;49576606+quinchs@users.noreply.github.com&gt;

---------

Co-authored-by: Misha133 &lt;61027276+Misha-133@users.noreply.github.com&gt;
Co-authored-by: Quin Lynch &lt;49576606+quinchs@users.noreply.github.com&gt;
diff --git a/src/Discord.Net.Rest/Entities/Interactions/InteractionHelper.cs b/src/Discord.Net.Rest/Entities/Interactions/InteractionHelper.cs
@@ -480,7 +480,9 @@ public static async Task DeleteFollowupMessageAsync(BaseDiscordClient client, Re
             }
             else
             {
-                var apiArgs = new UploadWebhookFileParams(args.Attachments.Value.ToArray())
+                var attachments = args.Attachments.Value?.ToArray() ?? Array.Empty<FileAttachment>();
+
+                var apiArgs = new UploadWebhookFileParams(attachments)
                 {
                     Content = args.Content,
                     Embeds = apiEmbeds?.ToArray() ?? Optional<API.Embed[]>.Unspecified,

Original file line number	Diff line number	Diff line change
`@@ -480,7 +480,9 @@ public static async Task DeleteFollowupMessageAsync(BaseDiscordClient client, Re`
`480`	`480`	`}`
`481`	`481`	`else`
`482`	`482`	`{`
`483`		`- var apiArgs = new UploadWebhookFileParams(args.Attachments.Value.ToArray())`
	`483`	`+ var attachments = args.Attachments.Value?.ToArray() ?? Array.Empty<FileAttachment>();`
	`484`	`+`
	`485`	`+ var apiArgs = new UploadWebhookFileParams(attachments)`
`484`	`486`	`{`
`485`	`487`	`Content = args.Content,`
`486`	`488`	`Embeds = apiEmbeds?.ToArray() ?? Optional<API.Embed[]>.Unspecified,`