Skip to content

Commit 5fb9152

Browse files
1NieRquinchs
andauthored
[Feature] Add missing remove property to MemberRoleAudit (#2675)
* Adding the missing remove property to MemberRoleAudit * fix * Update src/Discord.Net.WebSocket/Entities/AuditLogs/DataTypes/SocketMemberRoleEditInfo.cs Co-authored-by: Quin Lynch <[email protected]> * Update src/Discord.Net.Rest/Entities/AuditLogs/DataTypes/MemberRoleEditInfo.cs Co-authored-by: Quin Lynch <[email protected]> --------- Co-authored-by: Quin Lynch <[email protected]>
1 parent c922497 commit 5fb9152

File tree

4 files changed

+20
-4
lines changed

4 files changed

+20
-4
lines changed

src/Discord.Net.Rest/Entities/AuditLogs/DataTypes/MemberRoleAuditLogData.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ internal static MemberRoleAuditLogData Create(BaseDiscordClient discord, EntryMo
2222

2323
var roleInfos = changes.SelectMany(x => x.NewValue.ToObject<API.Role[]>(discord.ApiClient.Serializer),
2424
(model, role) => new { model.ChangedProperty, Role = role })
25-
.Select(x => new MemberRoleEditInfo(x.Role.Name, x.Role.Id, x.ChangedProperty == "$add"))
25+
.Select(x => new MemberRoleEditInfo(x.Role.Name, x.Role.Id, x.ChangedProperty == "$add", x.ChangedProperty == "$remove"))
2626
.ToList();
2727

2828
var userInfo = log.Users.FirstOrDefault(x => x.Id == entry.TargetId);

src/Discord.Net.Rest/Entities/AuditLogs/DataTypes/MemberRoleEditInfo.cs

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,12 @@ namespace Discord.Rest;
55
/// </summary>
66
public struct MemberRoleEditInfo
77
{
8-
internal MemberRoleEditInfo(string name, ulong roleId, bool added)
8+
internal MemberRoleEditInfo(string name, ulong roleId, bool added, bool removed)
99
{
1010
Name = name;
1111
RoleId = roleId;
1212
Added = added;
13+
Removed = removed;
1314
}
1415

1516
/// <summary>
@@ -35,4 +36,11 @@ internal MemberRoleEditInfo(string name, ulong roleId, bool added)
3536
/// <see langword="true" /> if the role was added to the user; otherwise <see langword="false" />.
3637
/// </returns>
3738
public bool Added { get; }
39+
/// <summary>
40+
/// Gets a value indicating that the user role has been removed.
41+
/// </summary>
42+
/// <returns>
43+
/// <c>true</c> if the role has been removed from the user; otherwise <c>false</c>.
44+
/// </returns>
45+
public bool Removed { get; }
3846
}

src/Discord.Net.WebSocket/Entities/AuditLogs/DataTypes/SocketMemberRoleAuditLogData.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ internal static SocketMemberRoleAuditLogData Create(DiscordSocketClient discord,
2222

2323
var roleInfos = changes.SelectMany(x => x.NewValue.ToObject<API.Role[]>(discord.ApiClient.Serializer),
2424
(model, role) => new { model.ChangedProperty, Role = role })
25-
.Select(x => new SocketMemberRoleEditInfo(x.Role.Name, x.Role.Id, x.ChangedProperty == "$add"))
25+
.Select(x => new SocketMemberRoleEditInfo(x.Role.Name, x.Role.Id, x.ChangedProperty == "$add", x.ChangedProperty == "$remove"))
2626
.ToList();
2727

2828
var cachedUser = discord.GetUser(entry.TargetId!.Value);

src/Discord.Net.WebSocket/Entities/AuditLogs/DataTypes/SocketMemberRoleEditInfo.cs

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,12 @@ namespace Discord.WebSocket;
55
/// </summary>
66
public struct SocketMemberRoleEditInfo
77
{
8-
internal SocketMemberRoleEditInfo(string name, ulong roleId, bool added)
8+
internal SocketMemberRoleEditInfo(string name, ulong roleId, bool added, bool removed)
99
{
1010
Name = name;
1111
RoleId = roleId;
1212
Added = added;
13+
Removed = removed;
1314
}
1415

1516
/// <summary>
@@ -33,4 +34,11 @@ internal SocketMemberRoleEditInfo(string name, ulong roleId, bool added)
3334
/// <see langword="true" /> if the role was added to the user; otherwise <see langword="false" />.
3435
/// </returns>
3536
public bool Added { get; }
37+
/// <summary>
38+
/// Gets a value indicating that the user role has been removed.
39+
/// </summary>
40+
/// <returns>
41+
/// <c>true</c> if the role has been removed from the user; otherwise <c>false</c>.
42+
/// </returns>
43+
public bool Removed { get; }
3644
}

0 commit comments

Comments
 (0)