feat: added error handling to recursive workload calculation

discopop-project · Nov 29, 2023 · 450cba5 · 450cba5
1 parent 1b48b92
commit 450cba5
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 9 deletions.
diff --git a/discopop_explorer/pattern_detectors/PatternInfo.py b/discopop_explorer/pattern_detectors/PatternInfo.py
@@ -78,7 +78,14 @@ def get_workload(self, pet: PETGraphX) -> int:
         """returns the workload of self._node"""
         if self.workload is not None:
             return self.workload
-        self.workload = calculate_workload(pet, self._node)
+        try:
+            self.workload = calculate_workload(pet, self._node)
+        except RecursionError as rerr:
+            import warnings
+
+            warnings.warn("Cost calculation not possible for node: " + str(self._node.id) + "!")
+            self.workload = 0
+
         return self.workload
 
     def get_per_iteration_workload(self, pet: PETGraphX) -> int:

diff --git a/discopop_explorer/utils.py b/discopop_explorer/utils.py
@@ -9,6 +9,7 @@
 from typing import List, Sequence, Set, Dict, Tuple, cast
 
 import numpy as np
+import warnings
 
 from .PETGraphX import (
     CUNode,
@@ -213,9 +214,15 @@ def calculate_per_iteration_workload_of_loop(pet: PETGraphX, node: Node) -> int:
             elif "for.cond" in cast(CUNode, child).basic_block_id:
                 continue
             else:
-                res += calculate_workload(pet, child)
+                try:
+                    res += calculate_workload(pet, child)
+                except RecursionError as rerr:
+                    warnings.warn("Cost calculation not possible for node: " + str(child.id) + "!")
         else:
-            res += calculate_workload(pet, child)
+            try:
+                res += calculate_workload(pet, child)
+            except RecursionError as rerr:
+                warnings.warn("Cost calculation not possible for node: " + str(child.id) + "!")
     return res
 
 

diff --git a/discopop_library/discopop_optimizer/PETParser/PETParser.py b/discopop_library/discopop_optimizer/PETParser/PETParser.py
@@ -9,6 +9,7 @@
 from typing import Dict, List, Tuple, Set
 
 import networkx as nx  # type: ignore
+import warnings
 
 from discopop_explorer.PETGraphX import (
     PETGraphX,
@@ -217,16 +218,21 @@ def __add_cu_nodes(self):
             self.cu_id_to_graph_node_id[cu_node.id] = new_node_id
             # calculate accessed data
             written_memory_regions, read_memory_regions = get_data_accesses_for_cu(self.pet, cu_node.id)
+            try:
+                parallelizable_workload = calculate_workload(
+                    self.pet, cu_node, ignore_function_calls_and_cached_values=True
+                )
+            except RecursionError as rerr:
+                warnings.warn("Cost calculation not possible for node: " + str(cu_node.id) + "!")
+                parallelizable_workload = 0
             self.graph.add_node(
                 new_node_id,
                 data=Workload(
                     node_id=new_node_id,
                     experiment=self.experiment,
                     cu_id=cu_node.id,
                     sequential_workload=0,
-                    parallelizable_workload=calculate_workload(
-                        self.pet, cu_node, ignore_function_calls_and_cached_values=True
-                    ),
+                    parallelizable_workload=parallelizable_workload,
                     written_memory_regions=written_memory_regions,
                     read_memory_regions=read_memory_regions,
                 ),
@@ -250,14 +256,19 @@ def __add_loop_nodes(self):
             # create new node for Loop
             new_node_id = self.get_new_node_id()
             self.cu_id_to_graph_node_id[loop_node.id] = new_node_id
+            try:
+                discopop_workload = calculate_workload(
+                    self.pet, loop_node, ignore_function_calls_and_cached_values=True
+                )
+            except RecursionError as rerr:
+                warnings.warn("Cost calculation not possible for node: " + str(loop_node.id) + "!")
+                discopop_workload = 0
             self.graph.add_node(
                 new_node_id,
                 data=Loop(
                     node_id=new_node_id,
                     cu_id=loop_node.id,
-                    discopop_workload=calculate_workload(
-                        self.pet, loop_node, ignore_function_calls_and_cached_values=True
-                    ),
+                    discopop_workload=discopop_workload,
                     iterations=iteration_count,
                     position=loop_node.start_position(),
                     experiment=self.experiment,