Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Notice: Array to string conversion #115

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

5baddi
Copy link

@5baddi 5baddi commented Mar 5, 2020

Fix Array to string conversion notice on src/Pinterest/Transport/Request.php

@dirkgroenen
Copy link
Owner

Thanks for your PR.
Unfortunately your PR contains a lot of composer and namespace changes which aren't related to the fix. Please update this so your PR only contains the fix.

@5baddi
Copy link
Author

5baddi commented Jun 3, 2021

Unnecessary changes have been removed.
Thank you 🙏🏼

Copy link

@jeandonaldroselin jeandonaldroselin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is ready for merge

@dirkgroenen dirkgroenen merged commit c043363 into dirkgroenen:master Sep 8, 2021
@dirkgroenen
Copy link
Owner

dirkgroenen commented Sep 8, 2021

Merged and released as 0.2.14, thanks!

jeandonaldroselin pushed a commit to siapepfrance/pinterest-php-client that referenced this pull request Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants