Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document exceptions to the deep query param #187

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

paescuj
Copy link
Contributor

@paescuj paescuj commented Feb 28, 2025

See directus/directus#24476 (comment) for the context.

@paescuj paescuj requested a review from a team as a code owner February 28, 2025 12:48
Copy link

vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 0:51am

@@ -399,7 +399,9 @@ const result = await directus.request(

## Deep

Set any query parameters on a nested relational dataset.
Deep allows you to set any of the other query parameters (expect for [Fields](#fields) and [Deep](#deep) itself) on a nested relational dataset.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Deep allows you to set any of the other query parameters (expect for [Fields](#fields) and [Deep](#deep) itself) on a nested relational dataset.
Deep allows you to set any of the other query parameters (except for [Fields](#fields) and [Deep](#deep) itself) on a nested relational dataset.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@paescuj Hey! Thanks for this. Is this correction okay?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes 😃👍

Copy link
Contributor

@hola-soy-milk hola-soy-milk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this!

@hola-soy-milk hola-soy-milk merged commit 2cfcb45 into main Mar 7, 2025
2 checks passed
@hola-soy-milk hola-soy-milk deleted the deep-query-param-exception branch March 7, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants