Squshed state of feature/hipified_prefill_v3#1
Merged
diptorupd merged 123 commits intofeature/hipified_prefill_v4from Oct 22, 2025
Merged
Squshed state of feature/hipified_prefill_v3#1diptorupd merged 123 commits intofeature/hipified_prefill_v4from
diptorupd merged 123 commits intofeature/hipified_prefill_v4from
Conversation
…efill_v3' into feature/hipified_prefill_v3
diptorupd
added a commit
that referenced
this pull request
Oct 22, 2025
Initial WIP implementation of a CDNA3 prefill kernel using WFMA intrinsic. All the work has been done on the SinglePrefillWithKVCacheDevice and the following kernels are completed: - `load_q_global_smem` - `produce_kv` - `compute_qk` - `update_mdo_states` Additionally, debug instrumentation for validating the `compute_sfm_v` is in progress. Unit test source is `/libflashinfer/tests/hip/test_single_prefill.cpp`
diptorupd
added a commit
that referenced
this pull request
Oct 22, 2025
Initial WIP implementation of a CDNA3 prefill kernel using WFMA intrinsic. All the work has been done on the SinglePrefillWithKVCacheDevice and the following kernels are completed: - `load_q_global_smem` - `produce_kv` - `compute_qk` - `update_mdo_states` Additionally, debug instrumentation for validating the `compute_sfm_v` is in progress. Unit test source is `/libflashinfer/tests/hip/test_single_prefill.cpp`
diptorupd
added a commit
that referenced
this pull request
Oct 22, 2025
Initial WIP implementation of a CDNA3 prefill kernel using WFMA intrinsic. All the work has been done on the SinglePrefillWithKVCacheDevice and the following kernels are completed: - `load_q_global_smem` - `produce_kv` - `compute_qk` - `update_mdo_states` Additionally, debug instrumentation for validating the `compute_sfm_v` is in progress. Unit test source is `/libflashinfer/tests/hip/test_single_prefill.cpp`
diptorupd
added a commit
that referenced
this pull request
Nov 9, 2025
Initial WIP implementation of a CDNA3 prefill kernel using WFMA intrinsic. All the work has been done on the SinglePrefillWithKVCacheDevice and the following kernels are completed: - `load_q_global_smem` - `produce_kv` - `compute_qk` - `update_mdo_states` Additionally, debug instrumentation for validating the `compute_sfm_v` is in progress. Unit test source is `/libflashinfer/tests/hip/test_single_prefill.cpp`
diptorupd
pushed a commit
that referenced
this pull request
Dec 5, 2025
This PR introduces a patch to includes
Tested with Unit Tests:
Test project /root/amd_eng/flashinfer/libflashinfer/tests/hip/build
Start 1: MathTest
1/4 Test #1: MathTest ......................... Passed 3.25 sec
Start 2: PosEncTest
2/4 Test #2: PosEncTest ....................... Passed 3.25 sec
Start 3: CascadeTest
3/4 Test #3: CascadeTest ...................... Passed 3.24 sec
Start 4: PageTest
4/4 Test #4: PageTest ......................... Passed 161.15 sec
100% tests passed, 0 tests failed out of 4
diptorupd
pushed a commit
that referenced
this pull request
Dec 5, 2025
This PR fixes some of the unit test failures that occur in Single
Decode. It also disables clang formatting of headers.
The clang format of headers causes compilation issues. The compiler is
unable to find `HIP WARP SYNC INTRINSICS` causing failures. Disabling
clang format fixes these issues
```
Start 1: MathTest
1/6 Test #1: MathTest ......................... Passed 3.31 sec
Start 2: PosEncTest
2/6 Test #2: PosEncTest ....................... Passed 3.36 sec
Start 3: CascadeTest
3/6 Test #3: CascadeTest ...................... Passed 3.35 sec
Start 4: PageTest
4/6 Test #4: PageTest ......................... Passed 114.08 sec
Start 5: SingleDecodeTest
5/6 Test #5: SingleDecodeTest ................. Passed 35.22 sec
Start 6: BatchDecodeTest
6/6 Test #6: BatchDecodeTest .................. Passed 559.75 sec
100% tests passed, 0 tests failed out of 6
Total Test time (real) = 719.07 sec
```
diptorupd
pushed a commit
that referenced
this pull request
Dec 5, 2025
CPP test suite was using `hipified` headers. In this PR, we port over unit tests to use `gpu_iface`. This is necessary for us as the next step is to move the build infrastructure to use `gpu_iface`
This PR has been tested locally
```
Test project /root/flashinfer/libflashinfer/tests/hip/build
Start 1: MathTest
1/6 Test #1: MathTest ......................... Passed 3.40 sec
Start 2: PosEncTest
2/6 Test #2: PosEncTest ....................... Passed 3.40 sec
Start 3: CascadeTest
3/6 Test #3: CascadeTest ...................... Passed 985.27 sec
Start 4: PageTest
4/6 Test #4: PageTest ......................... Passed 112.40 sec
Start 5: SingleDecodeTest
5/6 Test #5: SingleDecodeTest ................. Passed 35.46 sec
Start 6: BatchDecodeTest
6/6 Test #6: BatchDecodeTest .................. Passed 556.81 sec
100% tests passed, 0 tests failed out of 6
```
To replicate the tests
```
cd flashinfer/libflashinfer/tests/hip
```
```
mkdir build && cd build/
```
```
cmake -DCMAKE_PREFIX_PATH=/root/libtorch -DCMAKE_CXX_COMPILER:PATH=/opt/rocm/bin/amdclang++ -DFLASHINFER_INCLUDE_DIRS=/root/flashinfer/libflashinfer/include/ ..
```
```
make
```
```
ctest
```
diptorupd
pushed a commit
that referenced
this pull request
Dec 5, 2025
In this PR I remove the `libtorch` dependency and removed
`test_page.cpp`. `test_page.cpp` is the only unit test that uses
libtorch. However, we also have a pytest for testing page. We will use
that for validation.
Removing the libtorch dependency will help us speed docker builds and
remove additional dependencies.
```Test project /root/flashinfer/libflashinfer/tests/hip/build
Start 1: MathTest
1/8 Test #1: MathTest ............................ Passed 0.31 sec
Start 2: PosEncTest
2/8 Test #2: PosEncTest .......................... Passed 0.31 sec
Start 3: CascadeTest
3/8 Test #3: CascadeTest ......................... Passed 1369.12 sec
Start 4: SingleDecodeTest
4/8 Test #4: SingleDecodeTest .................... Passed 7726.35 sec
Start 5: BatchDecodeTest
5/8 Test #5: BatchDecodeTest ..................... Passed 811.61 sec
Start 6: test_mfma_fp32_16x16x16fp16
6/8 Test #6: test_mfma_fp32_16x16x16fp16 ......... Passed 0.30 sec
Start 7: test_transpose_4x4_half_registers
7/8 Test #7: test_transpose_4x4_half_registers ... Passed 0.28 sec
Start 8: test_rowsum
8/8 Test #8: test_rowsum ......................... Passed 0.27 sec
100% tests passed, 0 tests failed out of 8
```
diptorupd
pushed a commit
that referenced
this pull request
Jan 28, 2026
This PR introduces a patch to includes
Tested with Unit Tests:
Test project /root/amd_eng/flashinfer/libflashinfer/tests/hip/build
Start 1: MathTest
1/4 Test #1: MathTest ......................... Passed 3.25 sec
Start 2: PosEncTest
2/4 Test #2: PosEncTest ....................... Passed 3.25 sec
Start 3: CascadeTest
3/4 Test #3: CascadeTest ...................... Passed 3.24 sec
Start 4: PageTest
4/4 Test #4: PageTest ......................... Passed 161.15 sec
100% tests passed, 0 tests failed out of 4
diptorupd
pushed a commit
that referenced
this pull request
Jan 28, 2026
This PR fixes some of the unit test failures that occur in Single
Decode. It also disables clang formatting of headers.
The clang format of headers causes compilation issues. The compiler is
unable to find `HIP WARP SYNC INTRINSICS` causing failures. Disabling
clang format fixes these issues
```
Start 1: MathTest
1/6 Test #1: MathTest ......................... Passed 3.31 sec
Start 2: PosEncTest
2/6 Test #2: PosEncTest ....................... Passed 3.36 sec
Start 3: CascadeTest
3/6 Test #3: CascadeTest ...................... Passed 3.35 sec
Start 4: PageTest
4/6 Test #4: PageTest ......................... Passed 114.08 sec
Start 5: SingleDecodeTest
5/6 Test #5: SingleDecodeTest ................. Passed 35.22 sec
Start 6: BatchDecodeTest
6/6 Test #6: BatchDecodeTest .................. Passed 559.75 sec
100% tests passed, 0 tests failed out of 6
Total Test time (real) = 719.07 sec
```
diptorupd
pushed a commit
that referenced
this pull request
Jan 28, 2026
CPP test suite was using `hipified` headers. In this PR, we port over unit tests to use `gpu_iface`. This is necessary for us as the next step is to move the build infrastructure to use `gpu_iface`
This PR has been tested locally
```
Test project /root/flashinfer/libflashinfer/tests/hip/build
Start 1: MathTest
1/6 Test #1: MathTest ......................... Passed 3.40 sec
Start 2: PosEncTest
2/6 Test #2: PosEncTest ....................... Passed 3.40 sec
Start 3: CascadeTest
3/6 Test #3: CascadeTest ...................... Passed 985.27 sec
Start 4: PageTest
4/6 Test #4: PageTest ......................... Passed 112.40 sec
Start 5: SingleDecodeTest
5/6 Test #5: SingleDecodeTest ................. Passed 35.46 sec
Start 6: BatchDecodeTest
6/6 Test #6: BatchDecodeTest .................. Passed 556.81 sec
100% tests passed, 0 tests failed out of 6
```
To replicate the tests
```
cd flashinfer/libflashinfer/tests/hip
```
```
mkdir build && cd build/
```
```
cmake -DCMAKE_PREFIX_PATH=/root/libtorch -DCMAKE_CXX_COMPILER:PATH=/opt/rocm/bin/amdclang++ -DFLASHINFER_INCLUDE_DIRS=/root/flashinfer/libflashinfer/include/ ..
```
```
make
```
```
ctest
```
diptorupd
pushed a commit
that referenced
this pull request
Jan 28, 2026
In this PR I remove the `libtorch` dependency and removed
`test_page.cpp`. `test_page.cpp` is the only unit test that uses
libtorch. However, we also have a pytest for testing page. We will use
that for validation.
Removing the libtorch dependency will help us speed docker builds and
remove additional dependencies.
```Test project /root/flashinfer/libflashinfer/tests/hip/build
Start 1: MathTest
1/8 Test #1: MathTest ............................ Passed 0.31 sec
Start 2: PosEncTest
2/8 Test #2: PosEncTest .......................... Passed 0.31 sec
Start 3: CascadeTest
3/8 Test #3: CascadeTest ......................... Passed 1369.12 sec
Start 4: SingleDecodeTest
4/8 Test #4: SingleDecodeTest .................... Passed 7726.35 sec
Start 5: BatchDecodeTest
5/8 Test #5: BatchDecodeTest ..................... Passed 811.61 sec
Start 6: test_mfma_fp32_16x16x16fp16
6/8 Test #6: test_mfma_fp32_16x16x16fp16 ......... Passed 0.30 sec
Start 7: test_transpose_4x4_half_registers
7/8 Test #7: test_transpose_4x4_half_registers ... Passed 0.28 sec
Start 8: test_rowsum
8/8 Test #8: test_rowsum ......................... Passed 0.27 sec
100% tests passed, 0 tests failed out of 8
```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR squashes all commits in feature/hipified_prefill_v3 into the new feature/hipified_prefill_v4 branch.