diptorupd · 1e-to · Oct 4, 2020 · Oct 4, 2020 · Oct 4, 2020 · Oct 4, 2020
diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs
@@ -0,0 +1,4 @@
+# $ git config blame.ignoreRevsFile .git-blame-ignore-revs
+
+# Migrate code style to Black
+41ccd65e2e659aa0add0e5ab59f1a46e32cc4c46
diff --git a/.github/workflows/black.yml b/.github/workflows/black.yml
@@ -0,0 +1,28 @@
+# This is a workflow to format Python code with black formatter
+
+name: black
+
+# Controls when the action will run. Triggers the workflow on push or pull request
+# events but only for the master branch
+on:
+  push:
+    branches: [master]
+  pull_request:
+    branches: [master]
+
+# A workflow run is made up of one or more jobs that can run sequentially or in parallel
+jobs:
+  # This workflow contains a single job called "black"
+  black:
+    # The type of runner that the job will run on
+    runs-on: ubuntu-latest
+
+    # Steps represent a sequence of tasks that will be executed as part of the job
+    steps:
+      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
+      - uses: actions/checkout@v2
+      # Set up a Python environment for use in actions
+      - uses: actions/setup-python@v2
+
+      # Run black code formatter
+      - uses: psf/black@stable
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -0,0 +1,75 @@
+# Changelog
+All notable changes to this project will be documented in this file.
+
+## [Unreleased]
+### Added
+- Device descriptors "max_compute_units", "max_work_item_dimensions", "max_work_item_sizes", "max_work_group_size", "max_num_sub_groups" and "aspects" for int64 atomics inside dpctl C API and inside the dpctl.SyclDevice class.
+
+### Removed
+- The Legacy OpenCL interface.
+
+## [0.3.6] - 2020-10-06
+### Added
+- Changelog was added for dpctl.
+
+### Fixed
+- Windows build was fixed.
+
+## [0.3.5] - 2020-10-06
+### Added
+- Add a helper function to all Python SyclXXX classes to get the address of the base C API pointer as a long.
+
+### Changed
+- Rename PyDPPL to dpCtl in comments (function name renaming to come later)
+
+### Fixed
+- Fix bugs highlighted by tools.
+- Various code clean ups.
+
+## [0.3.4] - 2020-10-05
+### Added
+- Dump functions were enhanced to print back-end information.
+- dpctl gained support for unint_8 and unsigned long data types.
+- oneAPI Beta 10 tool chain support was added.
+
+### Changed
+- dpctl is now aware of DPC++ Sycl PI back-ends. The functionality is now exposed via the context interface.
+- C API's queue manager was refactored to require back-end.
+- dpct's device_context now requires back-end, device-type, and device-id to be provided in a string format, e.g. opencl:gpu:0.
+
+### Fixed
+- Fixed some important bugs found by static analysis.
+
+## [0.3.3] - 2020-10-02
+### Added
+- Add dpctl.get_curent_device_type().
+
+## [0.3.2] - 2020-09-29
+### Changed
+- Set _cpu_device and _gpu_device to None by default.
+
+## [0.3.1] - 2020-09-28
+### Added
+- Add get include and include headers.
+
+### Changed
+- DPPL shared objects are installed into dpctl.
+
+### Fixed
+- Refactor unit tests.
+
+## [0.3.0] - 2020-09-23
+### Added
+- Adds C and Cython API for portions of Sycl queue, device, context interfaces.
+- Implementing USM memory management.
+
+### Changed
+- Refactored API to expose a minimal sycl::queue interface.
+- Modify cpu_queues, gpu_queues and active_queues to functions.
+- Change static vectors to static pointers to verctors. It disables call for destructors. Destructors are also call in undefined order.
+- Rename package PyDPPL to dpCtl.
+- Use dpcpp.exe on Windows instead of dpcpp-cl.exe deleted in oneAPI beta08.
+
+### Fixed
+- Correct use ERRORLEVEL in conda scripts for Windows.
+- Fix using dppl.has_sycl_platforms() and dppl.has_gpu_queues() functions in skipIf
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -1,3 +1,10 @@
-Diptorup Deb
+# Python code style
 
-Todd Anderson
+## black
+
+We use [black](https://black.readthedocs.io/en/stable/) code formatter.
+
+- Revision: `20.8b1` or branch `stable`.
+- See configuration in `pyproject.toml`.
+
+Run before each commit: `black .`
diff --git a/README.md b/README.md
@@ -1,7 +1,8 @@
+[![Code style: black](https://img.shields.io/badge/code%20style-black-000000.svg)](https://github.com/psf/black)
+
 What?
 ====
-A lightweight Python package exposing a subset of OpenCL and SYCL
-functionalities.
+A lightweight Python package exposing a subset of SYCL functionalities.
 
 Requirements
 ============
@@ -27,14 +28,17 @@ On Windows to cope with [long file names](https://github.com/IntelPython/dpctl/i
 ```cmd
 conda build --croot=C:/tmp conda-recipe
 ```
+
+:warning: **You could face issues with conda-build=3.20**: Use conda-build=3.18!
+
 3. Install conda package
 ```bash
 conda install dpctl
 ```
 
-Using PyDPPL
-============
-PyDPPL relies on SYCL runtime. With Intel oneAPI installed you should activate it.
+Using dpCtl
+===========
+dpCtl relies on DPC++ runtime. With Intel oneAPI installed you should activate it.
 
 On Windows:
 ```cmd

diff --git a/backends/CMakeLists.txt b/backends/CMakeLists.txt
@@ -1,5 +1,5 @@
 cmake_minimum_required(VERSION 3.3.2 FATAL_ERROR)
-project("PyDPPL - A lightweight SYCL wrapper for Python")
+project("dpCtl - A lightweight SYCL wrapper for Python")
 
 # The function checks is DPCPP_ROOT is valid and points to a dpcpp installation
 function (check_for_dpcpp)
@@ -76,23 +76,14 @@ if(WIN32)
     set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Qstd=c++17")
     set(CMAKE_C_FLAGS_DEBUG "${CMAKE_C_FLAGS_DEBUG} -ggdb3 -DDEBUG ")
 elseif(UNIX)
-    set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS}                                        \
-       -Wall -Wextra -Winit-self -Wuninitialized -Wmissing-declarations        \
-       -fdiagnostics-color=auto -O3                                            \
-    ")
+    set(SDL_FLAGS "-fstack-protector -fstack-protector-all -fpic -fPIC -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -fno-strict-overflow -fno-delete-null-pointer-checks")
+    set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${SDL_FLAGS} -Wall -Wextra -Winit-self -Wuninitialized -Wmissing-declarations -fdiagnostics-color=auto")
     set(CMAKE_C_FLAGS_DEBUG "${CMAKE_C_FLAGS_DEBUG} -ggdb3 -DDEBUG ")
-    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++17 -fsycl")
+    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${SDL_FLAGS} -std=c++17 -fsycl")
 else()
     message(FATAL_ERROR "Unsupported system.")
 endif()
 
-
-set(OpenCL_INCLUDE_DIR "${DPCPP_ROOT}/include/sycl")
-set(OpenCL_LIBRARY "${DPCPP_ROOT}/lib/libOpenCL.so")
-
-message(STATUS "OpenCL_INCLUDE_DIR: ${OpenCL_INCLUDE_DIR}")
-message(STATUS "OpenCL_LIBRARY: ${OpenCL_LIBRARY}")
-
 add_library(
   DPPLSyclInterface
   SHARED
@@ -108,13 +99,6 @@ add_library(
   source/dppl_utils.cpp
 )
 
-# Install DPPLOpenCLInterface
-add_library(
-  DPPLOpenCLInterface
-  SHARED
-  source/dppl_opencl_interface.c
-)
-
 # Install DPPLSyclInterface
 target_include_directories(
   DPPLSyclInterface
@@ -124,18 +108,6 @@ target_include_directories(
   ${NUMPY_INCLUDE_DIR}
 )
 
-target_include_directories(
-    DPPLOpenCLInterface
-    PRIVATE
-    ${CMAKE_SOURCE_DIR}/include/
-)
-
-target_include_directories(
-    DPPLOpenCLInterface
-    PUBLIC
-    ${OpenCL_INCLUDE_DIR}
-)
-
 if(WIN32)
     message(
         STATUS
@@ -152,10 +124,6 @@ if(WIN32)
         PRIVATE ${DPCPP_ROOT}/lib/sycl.lib
         PRIVATE ${DPCPP_ROOT}/lib/OpenCL.lib
     )
-    target_link_libraries(
-        DPPLOpenCLInterface
-        PRIVATE ${DPCPP_ROOT}/lib/OpenCL.lib
-    )
 endif()
 
 install(
@@ -165,14 +133,6 @@ install(
   "${CMAKE_INSTALL_PREFIX}/lib/"
 )
 
-install(
-  TARGETS
-  DPPLOpenCLInterface
-  LIBRARY
-  DESTINATION
-  "${CMAKE_INSTALL_PREFIX}/lib/"
-)
-
 # Install all headers
 file(GLOB HEADERS "${CMAKE_SOURCE_DIR}/include/*.h*")
 foreach(HEADER ${HEADERS})
@@ -185,7 +145,7 @@ foreach(HEADER ${HEADERS})
   install(FILES "${HEADER}" DESTINATION include/Support)
 endforeach()
 
-# Enable to build the PyDPPL backend test cases
+# Enable to build the dpCtl backend test cases
 add_subdirectory(tests)
 
 # Todo : Add build rules for doxygen

diff --git a/backends/include/Support/CBindingWrapping.h b/backends/include/Support/CBindingWrapping.h
@@ -1,6 +1,6 @@
 //===----- Support/CBindingWrapping.h - DPPL-SYCL interface --*-- C ---*---===//
 //
-//               Python Data Parallel Processing Library (PyDPPL)
+//               Data Parallel Control Library (dpCtl)
 //
 // Copyright 2020 Intel Corporation
 //

diff --git a/backends/include/Support/DllExport.h b/backends/include/Support/DllExport.h
@@ -1,6 +1,6 @@
 //===---------- Support/DllExport.h - DPPL-SYCL interface ---*--- C ---*---===//
 //
-//               Python Data Parallel Processing Library (PyDPPL)
+//               Data Parallel Control Library (dpCtl)
 //
 // Copyright 2020 Intel Corporation
 //

diff --git a/backends/include/Support/ExternC.h b/backends/include/Support/ExternC.h
@@ -1,6 +1,6 @@
 //===------------ Support/ExternC.h - DPPL-SYCL interface ---*--- C ---*---===//
 //
-//               Python Data Parallel Processing Library (PyDPPL)
+//               Data Parallel Control Library (dpCtl)
 //
 // Copyright 2020 Intel Corporation
 //

diff --git a/backends/include/Support/MemOwnershipAttrs.h b/backends/include/Support/MemOwnershipAttrs.h
@@ -1,6 +1,6 @@
 //===----- dppl_mem_ownership_attrs.h - DPPL-SYCL interface --*-- C++ --*--===//
 //
-//               Python Data Parallel Processing Library (PyDPPL)
+//               Data Parallel Control Library (dpCtl)
 //
 // Copyright 2020 Intel Corporation
 //

diff --git a/backends/include/dppl_data_types.h b/backends/include/dppl_data_types.h
@@ -1,6 +1,6 @@
-//===---------- dppl_data_types.h - DPPL-SYCL interface ----*---- C ---*---===//
+//===------------------ dppl_data_types.h - dpctl-C_API ----*---- C ---*---===//
 //
-//               Python Data Parallel Processing Library (PyDPPL)
+//               Data Parallel Control Library (dpCtl)
 //
 // Copyright 2020 Intel Corporation
 //