Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update virtualScroll.component.ts #6

Merged
merged 5 commits into from
Dec 1, 2017
Merged

Commits on Jun 10, 2017

  1. Update virtualScroll.component.ts

    Hi Dinony,
    We experience poor scrolling performance in IE even if we set vsDebounceTime to a large value. After some investigation we have discovered that Angular change detection is triggered on each 'scroll' event despite debounceTime(). This can be prevented by wrapping Observable.fromEvent(..., 'scroll') in zone.runOutsideAngular().
    I couldn't figure out how to create a cold observable with Observable.fromEvent as if subscribe() is called outside of zone.runOutsideAngular() Angular change detection is still triggered on each scroll event. The proposed solution adds an intermediate scroll$ Subject.
    Kind regards,
    Serguei.
    zy-serguei authored Jun 10, 2017
    Configuration menu
    Copy the full SHA
    099fe23 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2017

  1. Test

    dinony committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    91b5a6b View commit details
    Browse the repository at this point in the history
  2. Revert "Test"

    This reverts commit 91b5a6b.
    dinony committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    352f407 View commit details
    Browse the repository at this point in the history
  3. Use const

    dinony committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    ee753f5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a5d0c27 View commit details
    Browse the repository at this point in the history