collection: fix SortedArray container #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * fix constructor to require explicit SortComparer object since GenericSortComparer may fail in the runtime due to absence of `>` and `<` operators. * fix clear() method to adhere to Collection behaviour; * call clear() from destructor.
dingmaotu
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
since GenericSortComparer may fail in the runtime due to
absence of
>and<operators.The problem with
SortCompareris that it should be specified explicitly. TheGenericSortComparerclass relies on>and<operators which may be not implemented for theTtype. That leads to "illegal operator use" compilation error for non-comparable types. Thus, this fix breaks SortedArray API.This is not the case for
EqualityComparerclass as==operator is defined for every conventional type as well as object pointers.