Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang: add Hash() on bool argument #34

Merged
merged 1 commit into from
Apr 2, 2018
Merged

Conversation

yerden
Copy link
Contributor

@yerden yerden commented Apr 2, 2018

Hash() implementations miss the one on bool argument. That makes compilation of EqualityComparer class to fail when creating collections containing bools, as in this code:

...
Vector<bool> m_op;
...

After compilation this codes leads to:

'Hash' - ambiguous call to overloaded function	EqualityComparer.mqh	40	66

This patch fixes compilation by overloading Hash() with bool argument.

Copy link
Owner

@dingmaotu dingmaotu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix! Thanks!

@dingmaotu dingmaotu merged commit 9e3b686 into dingmaotu:master Apr 2, 2018
@yerden yerden deleted the hash_fix branch April 2, 2018 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants