trade: add pool constructor options #33
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
OrderPool
to interface;OrderPoolMatcher
class;OrderMatcher
optional parameter forTradingPool
andHistoryPool
constructors.These changes don't violate current API and allow to reduce boilerplate code in case of defining
TradingPool
andHistoryPool
since matching criteria for both are often identical. It can also be useful when defining pools as RAII objects. For example: