Fix LinkedList memory leak bug when elements are not owned. Thanks Pa…

…ul Netherwood for reporting and fixing the bug
dingmaotu · Jun 20, 2018 · 0334e80 · 0334e80
1 parent 9824bae
commit 0334e80
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/Collection/LinkedList.mqh b/Collection/LinkedList.mqh
@@ -82,16 +82,15 @@ public:
 template<typename T>
 LinkedListBase::~LinkedListBase()
   {
-   if(m_owned)
+   LinkedNode<T>*n=m_head.next();
+   while(n!=m_tail)
      {
-      LinkedNode<T>*n=m_head.next();
-      while(n!=m_tail)
-        {
-         LinkedNode<T>*tempNode=n.next();
-         SafeDelete(n);
-         n=tempNode;
-        }
+      LinkedNode<T>*tempNode=n.next();
+      if(!m_owned) n.release();
+      SafeDelete(n);
+      n=tempNode;
      }
+
    SafeDelete(m_head);
    SafeDelete(m_tail);
   }