[DSHARE-1350] Add check for beacon implementation version #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #413 +/- ##
=======================================
Coverage 89.17% 89.17%
=======================================
Files 15 15
Lines 628 628
Branches 73 73
=======================================
Hits 560 560
Misses 68 68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ykim
requested changes
Mar 12, 2025
script/Release.s.sol
Outdated
| address beaconAddress, | ||
| address owner, | ||
| string memory currentVersion | ||
| ) internal returns (address) { | ||
| address implementation = _deployImplementation(contractName); |
There was a problem hiding this comment.
This shouldn't be happening at the start of this function because it should only happen if the beacon requires an upgrade or a new deployment.
ykim
approved these changes
Mar 12, 2025
joshualyguessennd
deleted the
DSHARE-1350-fix-beacon-deployment-previous-version-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Please link any clickup tickets, docs or other relevant context.
Description
Check implementation version before upgrading
Tests
What tests scenarios did you perform? Provide relevant screenshot/recordings here.