Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add features required by rusty-machine. #499

Merged
merged 14 commits into from
Feb 3, 2019
Merged

Add features required by rusty-machine. #499

merged 14 commits into from
Feb 3, 2019

Conversation

sebcrozet
Copy link
Member

@sebcrozet sebcrozet commented Dec 9, 2018

See #498.

@sebcrozet sebcrozet added this to the v0.17 milestone Dec 9, 2018
Copy link
Sponsor Contributor

@jswrenn jswrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be slightly more idiomatic to name these iterators Rows & RowsMut, and Cols and ColsMut.

Some examples of this pattern in the standard library include Chars and Values and ValuesMut.

@sebcrozet
Copy link
Member Author

@jswrenn I believe the convention is for the iterator type to have the same name as the method returning it. In our case the methods are row_iter(), row_iter_mut() etc, hence the RowIter, RowIterMut, etc names.

I didn't call those methods rows and rows_mut in the first place because those names are already used for slicing the matrix.

@jswrenn
Copy link
Sponsor Contributor

jswrenn commented Dec 9, 2018

I forgot about those methods! You're right about the convention. The name conflict is unfortunate.

@Coder-256 Coder-256 mentioned this pull request Dec 13, 2018
@sebcrozet sebcrozet added enhancement breaking change Fixing this issue, or merging this pull-request is likely to require breaking changes labels Dec 16, 2018
@sebcrozet
Copy link
Member Author

I'm merging this for today's release.
#499 is not fully fixed yet so we will open another PR to continue the work.

@sebcrozet sebcrozet merged commit 21c163d into master Feb 3, 2019
@sebcrozet sebcrozet deleted the rusty_machine branch February 3, 2019 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Fixing this issue, or merging this pull-request is likely to require breaking changes enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants