Skip to content

Conversation

@ThierryBerger
Copy link
Contributor

@ThierryBerger ThierryBerger commented Nov 4, 2024

Follow ups

Those are outside of scope for this PR:

background

@ThierryBerger ThierryBerger mentioned this pull request Nov 4, 2024
3 tasks
@ThierryBerger ThierryBerger changed the title update bevy to 0.15, commenting out bevy_egui Update bevy to 0.15 Nov 4, 2024
Copy link
Contributor

@mnmaita mnmaita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work here, looking forward to see this merged and released! I guess there's just a dependency bump blocker so I'm leaving an approval (with some minor nits).

On a different note, it would be great to see Required Components implemented in this library in future iterations.

@mnmaita
Copy link
Contributor

mnmaita commented Dec 2, 2024

Sorry but I did not check the CI failures but they seem pretty straightforward:

error[E0433]: failed to resolve: use of undeclared type `WindowPlugin`
  --> bevy_rapier_benches3d/src/common.rs:17:9
   |
17 |         WindowPlugin::default(),
   |         ^^^^^^^^^^^^
   |         |
   |         use of undeclared type `WindowPlugin`
   |         help: a struct with a similar name exists: `RenderPlugin`

That's probably because bevy_window feature is missing in the benchmarks cargo file.


And then there's a ton of lifetime elision lints (needless_lifetimes) which could be downgraded to warnings maybe?

@ThierryBerger
Copy link
Contributor Author

Thanks for your reviews!

it would be great to see Required Components implemented in this library in future iterations.

Copy link
Member

@sebcrozet sebcrozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks!

Co-authored-by: Sébastien Crozet <[email protected]>
@Abhinavpatel00
Copy link

when will this be merged? anything remaining? because almost all things are done except followups

@ThierryBerger ThierryBerger merged commit d87f7c2 into dimforge:master Dec 9, 2024
5 checks passed
@ThierryBerger
Copy link
Contributor Author

when will this be merged? anything remaining? because almost all things are done except followups

@Abhinavpatel00 This PR has been merged and the crates have been released now 👌

@Abhinavpatel00
Copy link

when will this be merged? anything remaining? because almost all things are done except followups

@Abhinavpatel00 This PR has been merged and the crates have been released now 👌

thank you for your great work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants