Skip to content

Indirectly update to libm 0.2#93

Merged
sebcrozet merged 1 commit intodimforge:devfrom
cuviper:libm-0.2
Jan 15, 2020
Merged

Indirectly update to libm 0.2#93
sebcrozet merged 1 commit intodimforge:devfrom
cuviper:libm-0.2

Conversation

@cuviper
Copy link
Copy Markdown
Contributor

@cuviper cuviper commented Jan 15, 2020

Unfortunately, libm 0.2 removed the F32Ext and F64Ext extension
traits, which makes it harder to choose the different methods. However,
this was already dealt with in rust-num/num-traits#144 for Float, so
we can piggy-back on that here, no longer using libm directly.

Unfortunately, `libm 0.2` removed the `F32Ext` and `F64Ext` extension
traits, which makes it harder to choose the different methods. However,
this was already dealt with in rust-num/num-traits#144 for `Float`, so
we can piggy-back on that here, no longer using `libm` directly.
@sebcrozet sebcrozet added breaking change Fixing this issue, or merging this pull-request is likely to require breaking changes enhancement labels Jan 15, 2020
@sebcrozet sebcrozet merged commit 412e693 into dimforge:dev Jan 15, 2020
@sebcrozet
Copy link
Copy Markdown
Member

Thanks!

@cuviper
Copy link
Copy Markdown
Contributor Author

cuviper commented Jan 15, 2020

I'm curious, why did you label this a breaking change?

@sebcrozet
Copy link
Copy Markdown
Member

Because of the change of version of num-traits. For example if for some arcane reasons someone has a foo crate with a dependency like num-traits = { version = "=0.2.10" }, the traits originating from num-traits used by alga won't be compatible with those used in foo.

@cuviper
Copy link
Copy Markdown
Contributor Author

cuviper commented Jan 15, 2020

Well, cargo won't resolve multiple semver-compatible crates in the dependency tree, so there can be only one num-traits 0.2.x at all. If a user has pinned num-traits like that, they just won't have a newer alga available to them. I think it would be unusual to treat that as a breaking change on your part.

@sebcrozet
Copy link
Copy Markdown
Member

Well, cargo won't resolve multiple semver-compatible crates in the dependency tree

Ah, good to know! Let's not mark this as breaking change then. Thank you for the explanation.

@sebcrozet sebcrozet removed the breaking change Fixing this issue, or merging this pull-request is likely to require breaking changes label Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants