Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable right click on control for options #35167

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mkangia
Copy link
Contributor

@mkangia mkangia commented Oct 3, 2024

Product Description

Simply disables options available on right clicking on a media player when viewing form attachment.

image

A follow up to #32490 to not provide users the option to download/save the media files.

Technical Summary

https://dimagi.atlassian.net/browse/SC-3952

Feature Flag

DISABLE_FORM_ATTACHMENT_DOWNLOAD_IN_BROWSER

Safety Assurance

Safety story

Tested by making the change in the browser that the controls are not visible anymore. Its a HTML only change, behind a feature flag that should not impact anything outside the feature flag.

Automated test coverage

QA Plan

No QA planned.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@mkangia mkangia marked this pull request as ready for review October 3, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant