Skip to content

Remove oauth_integrations app#34109

Closed
millerdev wants to merge 5 commits intomasterfrom
dm/rm-google-oauth
Closed

Remove oauth_integrations app#34109
millerdev wants to merge 5 commits intomasterfrom
dm/rm-google-oauth

Conversation

@millerdev
Copy link
Copy Markdown
Contributor

Removes an unused app developed for Google Sheets integration, which was never released. The main motivation for this is to remove the dependencies that it added. If we add Gsheets integration in the future we should consider using oauth libraries that we use elsewhere to minimize the number of dependencies we need to maintain.

Safety Assurance

Safety story

Nothing references this app. The /oauth/google_sheets_* URL patterns have not been hit on production for over 2 months.

Automated test coverage

No.

Migrations

  • The migrations in this code can be safely applied first independently of the code since the code is not being used (there would be 500 errors if the removed URL patterns were accessed).

Rollback instructions

  • A reverse migration will need to be developed if we want to revert this PR.

@millerdev millerdev added the product/invisible Change has no end-user visible impact label Feb 9, 2024
@millerdev millerdev requested review from gherceg and snopoke February 9, 2024 16:27
@millerdev millerdev requested a review from a team as a code owner February 9, 2024 16:27
@dimagimon dimagimon added dependencies Pull requests that update a dependency file reindex/migration Reindex or migration will be required during or before deploy labels Feb 9, 2024
@millerdev millerdev marked this pull request as draft February 9, 2024 16:38
@millerdev millerdev added the Open for review: do not merge A work in progress label Feb 9, 2024
@millerdev millerdev removed the Open for review: do not merge A work in progress label Feb 12, 2024
@millerdev
Copy link
Copy Markdown
Contributor Author

Closing since it sounds like some of this may be useful after all.

@millerdev millerdev closed this Feb 12, 2024
@millerdev
Copy link
Copy Markdown
Contributor Author

google-auth-oauthlib upgraded by #33873

jingcheng16 added a commit that referenced this pull request Nov 25, 2024
jingcheng16 added a commit that referenced this pull request Nov 25, 2024
jingcheng16 added a commit that referenced this pull request Nov 25, 2024
@millerdev millerdev deleted the dm/rm-google-oauth branch March 20, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file product/invisible Change has no end-user visible impact reindex/migration Reindex or migration will be required during or before deploy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants