[Ignore] Example PR for lint-action (flake8) with action-lint (eslint) #33280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Moved to draft since the PR's meant as an example, not to be merged) |
Charl1996
force-pushed
the
cs/revisit-linter
branch
from
1ba74da
to
ec626cd
Compare
|
I like this. |
|
Agreed that this seems like a huge improvement! |
|
Like the annotations much better than lint errors in log output. |
|
Can I go ahead and implement this across some repos (hq and cloud)? |
|
Seems like a good idea to me if everything is working as expected. |
This was referenced Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only an example PR showing the results of lint-action (for python flake8) and action-lint (for js eslint).
Notes
Both action-lint and lint-action runs on changed files, not only line diffs.
The python and js linting runs as two different GH jobs, otherwise the tool than runs last will not output the results as github annotations.
(See also this document)