Merged
Conversation
dimagimon
reviewed
Oct 31, 2016
| } | ||
| }; | ||
| _private.navigateBack = function() { | ||
| var previewWindow = $appPreviewIframe[0].contentWindow; |
Collaborator
There was a problem hiding this comment.
'$appPreviewIframe' is not defined. (no-undef)
Contributor
There was a problem hiding this comment.
this is a real bug but will be fixed in a later PR (not critical feature that is behind preview flag)
dimagimon
reviewed
Oct 31, 2016
| }, | ||
| balancePreview: function () { | ||
| // set with setBalancePreviewFn in utils. | ||
| } |
Collaborator
There was a problem hiding this comment.
Missing trailing comma. (comma-dangle)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to
preview_app.jscodeother stuff is just moving templates over, adding some styles and adding the framework to generate diffs of the template and partials files. no
v1files should be changed except for the preview updates.@benrudolph / @orangejenny
Note: most of the added new lines come from new fonts and copied templates to
v2