Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload the current page on SIGUSR1 signal #290

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Reload the current page on SIGUSR1 signal #290

merged 1 commit into from
Oct 28, 2024

Conversation

rodarima
Copy link
Member

@rodarima rodarima commented Oct 25, 2024

Fixes: #255

Known limitations: External CSS and images are not fetched again, refetching them again causes issues.

@rodarima rodarima added this to the Release 3.2.0 milestone Oct 25, 2024
@rodarima
Copy link
Member Author

rodarima commented Oct 25, 2024

This only operates on the first tab, even if it is out of focus. Once the first tab is closed, reloading via the signal causes a crash.

We will need to operate only on the "current" tab. If we have multiple windows, I assume we either reload the current tab on all windows, or just one of them.

Let's reload all of them for now.

src/uicmd.cc Outdated Show resolved Hide resolved
Reloads the current page on all windows when the SIGUSR1 is received.
This is useful to update the page when it is being edited.

Fixes: #255
@rodarima rodarima merged commit 27f88f0 into master Oct 28, 2024
22 checks passed
@rodarima rodarima deleted the reload-sigusr branch November 3, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reload current page on SIGUSR1
1 participant