Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use command -v instead of which #265

Closed
wants to merge 1 commit into from

Conversation

xlex8
Copy link
Contributor

@xlex8 xlex8 commented Oct 3, 2024

Makes the build POSIX compliant by not using 'which'

@xlex8
Copy link
Contributor Author

xlex8 commented Oct 3, 2024

@Kangie @eli-schwartz
This should fix the issue with 'which'

@rodarima
Copy link
Member

rodarima commented Oct 3, 2024

Thanks Alex. Merging with capitalized "Use" in the commit message.

@rodarima
Copy link
Member

rodarima commented Oct 3, 2024

Merged here: 9880c1b

@rodarima rodarima closed this Oct 3, 2024
@rodarima rodarima added this to the Release 3.2.0 milestone Oct 3, 2024
@xlex8 xlex8 deleted the new_branch branch October 4, 2024 13:59
@eli-schwartz
Copy link

@Kangie @eli-schwartz This should fix the issue with 'which'

I had pointed out in the associated issue that this isn't really the correct fix, but oh well. :)

@rodarima
Copy link
Member

rodarima commented Oct 6, 2024

I had pointed out in the associated issue that this isn't really the correct fix, but oh well. :)

The issue #262 states that the problem is that the configure uses which(1), which is not posix compliant and there is no dependency documented anywhere. Using command -v makes the configure process posix compliant, so it is one correct solution to the problem.

Additionally, it makes Dillo remove the dependency over which(1), so that is a bonus.

I'm aware of AC_PATH_PROG to search for programs, just it is not needed for this particular case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants