Skip to content

Fixed use of "window" instead of "global". #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dignifiedquire merged 1 commit into from
Jan 14, 2017
Merged

Fixed use of "window" instead of "global". #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webcrypto-shim.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ module.exports = function webcryptoShim (global) {
_SubtleCrypto = global.SubtleCrypto || _subtle.constructor || Object,
_CryptoKey = global.CryptoKey || global.Key || Object;

var isEdge = window.navigator.userAgent.indexOf('Edge/') > -1
var isEdge = global.navigator.userAgent.indexOf('Edge/') > -1

@dignifiedquire dignifiedquire Jan 14, 2017 •
edited
Loading

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think global is defined in all browsers, maybe check for not being undefined in this order

  1. global
  2. window
  3. self

@tswindell tswindell Jan 14, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

global is a local variable, it is the variable that is assigned to window or self.

@dignifiedquire dignifiedquire Jan 14, 2017

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should read the code I'm reviewing more closely :/

var isIE = !!global.msCrypto && !isEdge,
isWebkit = !!_crypto.webkitSubtle;
if ( !isIE && !isWebkit ) return;
Expand Down