Build production and development JS builds in gulp watch #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le to test production builds
|
👍 |
|
First thing I notice is that eslint fails tests. Need to add prod to excludes in unit tests but also many dev files cause eslint errors. Also phpcs doesn't pass through. Can you check these to be failsafe @Niq1982? I'll test the other JS build processes soon-ish. |
…te gutenberg build
timiwahalahti
suggested changes
Feb 19, 2021
…air-light into prod-and-dev-js-builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As decided earlier this year in our dev-retreat: Change JS builds so they build development and production bundles and load them in WP according to the
WP_ENVvariable.Also, added the possibility to use URL parameter
?load_production_buildsfor testing production builds (Both JS and CSS) in development environment.