Fix builder parameter #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yo Kinda need this, so Im going to ask the maintainer of a fork of this to merge it in. 😅 I hope you are ok with me forking your 2 year old fork and rebasing it with https://github.com/ahmed-eg/virtual_keyboard_multi_language and making the PR on behalf of you. |
|
Its merged in. if you want you can shift to that package on pub dev |
|
Wow! It's been such a long time, I barely remember where I used this library 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The builder parameter passed to the widget ignored since it's not being copied to the state. This tiny pull request fixes it.
Btw, is there a reason for copying the attributes to the state instead of just referencing the widget attributes directly via
widget.builder?