Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[droplets]: add support for backup policy #1261

Merged
merged 20 commits into from
Nov 12, 2024

Conversation

loosla
Copy link
Contributor

@loosla loosla commented Oct 31, 2024

This PR adds a support for Droplet backup policy.

@loosla loosla marked this pull request as ready for review November 4, 2024 17:32
@loosla loosla requested review from andrewsomething and a team and removed request for andrewsomething November 4, 2024 17:32
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Great work!

Whether in this PR or in a fast follow, we should add this to the docs as well:

https://github.com/digitalocean/terraform-provider-digitalocean/blob/main/docs/resources/droplet.md#argument-reference

@loosla
Copy link
Contributor Author

loosla commented Nov 12, 2024

@andrewsomething Hey Andrew, thanks for the reminder to update the doc!
Could you take a look when you have some time - docs/resources/droplet.md 🙏
I think it makes sense to include this in the PR.

Co-authored-by: Andrew Starr-Bochicchio <[email protected]>
@loosla loosla merged commit 2c9f219 into main Nov 12, 2024
3 checks passed
@loosla loosla deleted the alushnikova/add-droplet-backup-policy branch November 12, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants