Skip to content

Remove Sphinx as dependency #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2022
Merged

Remove Sphinx as dependency #148

merged 1 commit into from
Dec 13, 2022

Conversation

danaelhe
Copy link
Member

Removing sphinx as dependency and keeping it as a dev-dependencies in an effort to shrink package size.

@danaelhe danaelhe requested a review from a team December 13, 2022 16:32
andrewsomething
andrewsomething approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@ChiefMateStarbuck ChiefMateStarbuck merged commit b4d5aae into main Dec 13, 2022
@ChiefMateStarbuck ChiefMateStarbuck deleted the sphinx_dev_dep branch December 13, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsomething andrewsomething andrewsomething approved these changes

@ChiefMateStarbuck ChiefMateStarbuck ChiefMateStarbuck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danaelhe @andrewsomething @ChiefMateStarbuck